Added self-contained http/network requests implementation #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehsandeep
reviewed
Oct 14, 2021
There was a problem hiding this comment.
Host header is not considered in RAW format compared to base format, additionally, we can extend this support for network templates as well.
Base format:-
id: example-self-contained-input-2
info:
name: example-self-contained-input-2
author: pdteam
severity: info
self-contained: true
requests:
- path:
- "https://example.com/gg"
headers:
Host: "{{randstr}}.tld"
matchers:
- type: status
status:
- 302RAW format:-
id: example-self-contained-input
info:
name: example-self-contained
author: pdteam
severity: info
self-contained: true
requests:
- raw:
- |
GET https://example.com/gg HTTP/1.1
Host: {{randstr}}.tld
matchers:
- type: status
status:
- 302
ehsandeep
added
the
Status: In Progress
… self-contained-templates
… self-contained-templates
Ice3man543
changed the title
|
Added the support to network requests as well which is now possible after the merge of #1138. id: api-sendgrid
info:
name: Sendgrid API Test
author: zzeitlin
reference: https://docs.sendgrid.com/for-developers/sending-email/getting-started-smtp
severity: info
tags: token-spray,sendgrid
self-contained: true
network:
- inputs:
- data: "ehlo\r\n"
read: 1024
- data: "AUTH PLAIN {{base64(hex_decode('00')+'apikey'+hex_decode('00')+token)}}\r\n"
read: 1024
host:
- "tls://smtp.sendgrid.net:465"
matchers:
- type: word
words:
- "Authentication successful" |
… self-contained-templates
ehsandeep
added
Status: Completed
ehsandeep
approved these changes
Oct 18, 2021
forgedhallpass
suggested changes
Oct 18, 2021
There was a problem hiding this comment.
As mentioned in my previous comment (#1086 (comment)), I believe the self-contained attribute should be declared per-template level and not per-request etc.
forgedhallpass
suggested changes
Oct 18, 2021
|
Changed it to be per-template instead. id: example-self-contained-input
info:
name: example-self-contained
author: pdteam
severity: info
self-contained: true
requests:
- raw:
- |
GET https://example.com/gg HTTP/1.1
Host: {{randstr}}.tld
matchers:
- type: status
status:
- 302 |
forgedhallpass
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1086 by adding a new attribute to HTTP requests that marks all the HTTP Requests in that template as self-sufficient, meaning they do not require any input to be executed.
Few examples are provided below. The attribute was added to HTTP requests as the implementation was only relevant for HTTP.