Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added high level nuclei architecture overview #1177

Merged
merged 8 commits into from
Nov 12, 2021
Merged

Added high level nuclei architecture overview #1177

merged 8 commits into from
Nov 12, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Oct 24, 2021 •
edited by ehsandeep
Loading

Proposed changes

Added high-level nuclei architecture overview.

TODO:

  • Adding new protocol overview

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep marked this pull request as draft October 24, 2021 06:53
@ehsandeep ehsandeep added the Status: In Progress This issue is being worked on, and has someone assigned. label Oct 24, 2021
@ehsandeep ehsandeep mentioned this pull request Nov 10, 2021
Closed
1 task
@ehsandeep ehsandeep linked an issue Nov 10, 2021 that may be closed by this pull request
Adding high level nuclei architecture overview document #1238
Closed
1 task
@ehsandeep
Copy link
Member

depends on #1066

@Ice3man543 Ice3man543 marked this pull request as ready for review November 11, 2021 23:19
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 12, 2021
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 12, 2021
@ehsandeep ehsandeep merged commit 7af5121 into dev Nov 12, 2021
@ehsandeep ehsandeep deleted the design-md branch November 12, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding high level nuclei architecture overview document
3 participants
@Ice3man543 @ehsandeep @Mzack9999