-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error log option #1204
Add error log option #1204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything working well as described in the issue @zerodivisi0n 👏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me, very nice work @zerodivisi0n!
Regarding showing absolute paths, i guess it's okay for us to show absolute paths since those would be easy to open through the error log. Also unwrapping like that is the accepted way of getting the last error, so It shouldn't be an issue. |
@ehsandeep , @Ice3man543 , great! Thanks for the quick review! |
Proposed changes
Implements error log feature (#1187)
Original issue checklist:
Differences from the original issue:
Unwrap
to get the last wrapped error. I don't know how bad it is.Example of output:
Checklist