-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat #1092: Validate binary values + precompile them as well #1213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The associated ticket was about validating hex values from templates when the -validate flag is used. Instead of doing so, this PR seems to change the functionality itself. Have you checked if content highlighting with the -debug flag still works after this change?
Basically what i did was move the binary hex decoding to the |
You are right, when I looked at the code I relied on the name of the variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo 1.1.1.1 | ./nuclei -t a.yaml -validate
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ 2.5.4-dev
projectdiscovery.io
[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[ERR] Error occurred parsing template test.yaml: could not compile request: could not compile operators: could not compile matcher: could not hex decode binary: 00700000200000002000000
[FTL] Could not run nuclei: an error occurred during templates validation
… validate-binary
Proposed changes
Closes #1092
Checklist