Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique Interactsh URL #1219

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Unique Interactsh URL #1219

merged 3 commits into from
Nov 5, 2021

Conversation

parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Nov 4, 2021 •
edited
Loading

Proposed changes

closes #1068

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep linked an issue Nov 4, 2021 that may be closed by this pull request
Unique payload per Interactsh placeholder #1068
Closed
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 4, 2021
forgedhallpass
forgedhallpass suggested changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@forgedhallpass forgedhallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write at least one unit test that validates the changes.

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 5, 2021
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Nov 5, 2021
ehsandeep
ehsandeep approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally

Ice3man543
Ice3man543 approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 5, 2021
@ehsandeep ehsandeep merged commit 3c53e26 into dev Nov 5, 2021
@ehsandeep ehsandeep deleted the uniq-interact branch November 5, 2021 22:03
@ehsandeep ehsandeep removed the request for review from forgedhallpass November 5, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forgedhallpass forgedhallpass forgedhallpass requested changes

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique payload per Interactsh placeholder
4 participants
@parrasajad @ehsandeep @forgedhallpass @Ice3man543