Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1173: perform matching on all redirect responses instead of final #1232

Merged
merged 5 commits into from
Nov 10, 2021
Merged

fix #1173: perform matching on all redirect responses instead of final #1232

merged 5 commits into from
Nov 10, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Nov 9, 2021 •
edited
Loading

Proposed changes

Changed the HTTP execution logic so that the match on HTTP response is performed for all redirect chain response separately, with the final response being matched on first, and the chain of all the responses leading up to the final responses checked next.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue Nov 9, 2021 that may be closed by this pull request
Redirects support matching on final response only #1173
Closed
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 9, 2021
@ehsandeep ehsandeep merged commit 66074a1 into dev Nov 10, 2021
@ehsandeep ehsandeep deleted the fix-redirect-response-bug branch November 10, 2021 12:08
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirects support matching on final response only
3 participants
@Ice3man543 @ehsandeep @Mzack9999