-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dns trace support in dns templates #1236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
Type: Enhancement
Most issues will probably ask for additions or changes.
Status: Blocked
There is some issue that needs to be resolved first.
labels
Nov 9, 2021
Mzack9999
added
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 10, 2021
ehsandeep
removed
the
Status: Blocked
There is some issue that needs to be resolved first.
label
Nov 10, 2021
ehsandeep
approved these changes
Nov 10, 2021
ehsandeep
added
the
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
label
Nov 10, 2021
Ice3man543
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ehsandeep
approved these changes
Nov 18, 2021
ehsandeep
removed
the
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
label
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
Type: Enhancement
Most issues will probably ask for additions or changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds dns trace support for dns templates
Checklist
Blocker
Dynamic extractors are currently not working across different requests - depends on #1047