Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dns trace support in dns templates #1236

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Nov 9, 2021

Proposed changes

This PR adds dns trace support for dns templates

id: test-trace

info:
  name: Test Trace
  author: pdteam
  severity: info
  tags: dns

dns:
  - name: "{{FQDN}}"
    type: A
    class: inet
    recursion: true
    retries: 3
    trace: true
    trace-max-recursion: 10
    
    extractors:
      - type: regex
        part: trace
        group: 1
        regex:
          - "IN\tNS\t(.+)"
          - "IN\\s+NS\\s+(.+)"
echo hackerone.com | ./nuclei -test.yaml -debug

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Blocker

Dynamic extractors are currently not working across different requests - depends on #1047

@Mzack9999 Mzack9999 self-assigned this Nov 9, 2021
@Mzack9999 Mzack9999 added Type: Enhancement Most issues will probably ask for additions or changes. Status: Blocked There is some issue that needs to be resolved first. labels Nov 9, 2021
@Mzack9999 Mzack9999 marked this pull request as draft November 9, 2021 18:43
@Mzack9999 Mzack9999 linked an issue Nov 9, 2021 that may be closed by this pull request
@Mzack9999 Mzack9999 marked this pull request as ready for review November 10, 2021 14:24
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 10, 2021
@ehsandeep ehsandeep removed the Status: Blocked There is some issue that needs to be resolved first. label Nov 10, 2021
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 10, 2021
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit 7f5f791 into dev Nov 18, 2021
@ehsandeep ehsandeep deleted the issue-419-dns-trace branch November 18, 2021 13:52
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DNS Trace for DNS Templates
3 participants