-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for aws request signing #1247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Enhancement
Most issues will probably ask for additions or changes.
label
Nov 12, 2021
template example: id: aws
info:
name: AWS Test
author: test
severity: info
self-contained: true
signature: aws
requests:
- raw:
- |
POST https://{test.test.amazonaws.com/ HTTP/1.1
Host: test.test.amazonaws.com
Accept-Encoding: gzip, deflate
Action=test |
Mzack9999
added
the
Status: In Progress
This issue is being worked on, and has someone assigned.
label
Nov 26, 2021
Fixes indirectly #844
Indirectly fixes #844 |
Mzack9999
added
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
and removed
Status: In Progress
This issue is being worked on, and has someone assigned.
labels
Nov 26, 2021
Ice3man543
reviewed
Dec 2, 2021
Ice3man543
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ehsandeep
requested changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go run . -duc -no-interactsh -t aws-test.yaml
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ 2.5.4
projectdiscovery.io
[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[INF] Using Nuclei Engine 2.5.4 (outdated)
[INF] Using Nuclei Templates 8.7.3 (latest)
[INF] Using Interactsh Server https://interactsh.com
[INF] Templates added in last update: 5
[INF] Templates loaded for scan: 1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x20 pc=0x10325b010]
goroutine 55 [running]:
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*generatedRequest).URL(...)
/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/build_request.go:46
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*Request).ExecuteWithResults.func1({0x1400020e180, 0x162}, 0x0, 0x14000072150)
/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/request.go:253 +0x1c0
github.com/projectdiscovery/nuclei/v2/pkg/protocols/http.(*Request).ExecuteWithResults(0x140000e2420, {0x0, 0x0}, 0x14000072150, 0x140000721b0, 0x14000072330)
/Users/geekboy/Github/nuclei/v2/pkg/protocols/http/request.go:315 +0x280
github.com/projectdiscovery/nuclei/v2/pkg/protocols/common/executer.(*Executer).Execute(0x140004bfd60, {0x0, 0x0})
/Users/geekboy/Github/nuclei/v2/pkg/protocols/common/executer/executer.go:51 +0x1c4
github.com/projectdiscovery/nuclei/v2/pkg/core.(*Engine).executeSelfContainedTemplateWithInput(0x140000e2160, 0x140004cf6c0, 0x1400003b400)
/Users/geekboy/Github/nuclei/v2/pkg/core/execute.go:60 +0x38
github.com/projectdiscovery/nuclei/v2/pkg/core.(*Engine).ExecuteWithOpts.func1(0x140000e2160, 0x1400003b400, 0x3, {0x103bf16d8, 0x140004be080}, 0x140004bed60, 0x140004cf6c0)
/Users/geekboy/Github/nuclei/v2/pkg/core/execute.go:46 +0x40
created by github.com/projectdiscovery/nuclei/v2/pkg/core.(*Engine).ExecuteWithOpts
/Users/geekboy/Github/nuclei/v2/pkg/core/execute.go:42 +0x13c
exit status 2
ehsandeep
added
Status: Revision Needed
Submitter of PR needs to revise the PR related to the issue.
and removed
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
labels
Dec 16, 2021
Mzack9999
added
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
and removed
Status: Revision Needed
Submitter of PR needs to revise the PR related to the issue.
labels
Dec 16, 2021
ehsandeep
approved these changes
Dec 19, 2021
ehsandeep
added
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
and removed
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
labels
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
Type: Enhancement
Most issues will probably ask for additions or changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds a prototype support for AWS requests signing
Checklist