Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed stdin input parsing bug causing nuclei to hang #1286

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Fixed stdin input parsing bug causing nuclei to hang #1286

merged 1 commit into from
Nov 27, 2021

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Nov 23, 2021 •
edited
Loading

Proposed changes

There was a typo in the stdin parsing which resulted in nuclei trying to read stdin which caused it to get stuck when spawned as child process in some cases.

This should hopefully fix #1274 (tested) and #1265 (untested, to be tested)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 linked an issue Nov 23, 2021 that may be closed by this pull request
Spawned nuclei (child) process hangs #1274
Closed
@Ice3man543 Ice3man543 mentioned this pull request Nov 23, 2021
Closed
@Ice3man543 Ice3man543 self-assigned this Nov 23, 2021
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Nov 23, 2021
@ehsandeep ehsandeep merged commit b59582b into dev Nov 27, 2021
@ehsandeep ehsandeep deleted the fix-stdin-parser branch November 27, 2021 23:01
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Nov 27, 2021
@ehsandeep ehsandeep restored the fix-stdin-parser branch November 27, 2021 23:54
ehsandeep added a commit that referenced this pull request Nov 28, 2021
@ehsandeep
Revert "Fixed stdin input parsing bug (#1286)"
75333da 
This reverts commit b59582b.
@ehsandeep ehsandeep deleted the fix-stdin-parser branch December 2, 2021 18:56
@ehsandeep ehsandeep mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spawned nuclei (child) process hangs
2 participants
@Ice3man543 @ehsandeep