Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving headless test cases #1313

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Improving headless test cases #1313

merged 3 commits into from
Dec 4, 2021

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Nov 30, 2021 •
edited
Loading

Proposed changes

This PR add basic tests coverage for headless mode

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Notes:

  • After multiple runs no zombie processes were detected on OSX, Win11 and Ubuntu (all amd64)
  • Complex headless workflows should be tested against different frontends (eg. angular, jquery, etc). Either custom infra (scanme.projectdiscovery.io?) or docker containers?
  • No need to setup chrome on the github worker, it seems like it's already present

@Mzack9999 Mzack9999 self-assigned this Nov 30, 2021
@Mzack9999 Mzack9999 added Status: In Progress This issue is being worked on, and has someone assigned. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. labels Nov 30, 2021
@Mzack9999 Mzack9999 linked an issue Nov 30, 2021 that may be closed by this pull request
Headless Mode Improvements #749
Closed
2 tasks
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Nov 30, 2021
@ehsandeep ehsandeep merged commit 8336421 into dev Dec 4, 2021
@ehsandeep ehsandeep deleted the issue-749-headless-tests branch December 4, 2021 17:40
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Headless Mode Improvements
3 participants
@Mzack9999 @ehsandeep @Ice3man543