Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support major os #1347

Merged
merged 6 commits into from
Dec 16, 2021
Merged

Support major os #1347

merged 6 commits into from
Dec 16, 2021

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Dec 8, 2021 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@LuitelSamikshya LuitelSamikshya marked this pull request as draft December 8, 2021 21:27
@Mzack9999 Mzack9999 mentioned this pull request Dec 10, 2021
Merged
4 tasks
@LuitelSamikshya LuitelSamikshya self-assigned this Dec 10, 2021
@LuitelSamikshya LuitelSamikshya added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 10, 2021
@LuitelSamikshya LuitelSamikshya marked this pull request as ready for review December 10, 2021 20:21
@LuitelSamikshya LuitelSamikshya linked an issue Dec 10, 2021 that may be closed by this pull request
Run the integration tests on all major operating systems #1322
Closed
3 tasks
Mzack9999
Mzack9999 requested changes Dec 11, 2021
View reviewed changes
.github/workflows/build-test.yml Outdated Show resolved Hide resolved
.github/workflows/functional-test.yml Outdated Show resolved Hide resolved
Mzack9999
Mzack9999 approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, errors in tests are expected and tracked at #1380 and #1381

@ehsandeep ehsandeep merged commit 3f86bc7 into dev Dec 16, 2021
@ehsandeep ehsandeep deleted the support-major-os branch December 16, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@forgedhallpass forgedhallpass Awaiting requested review from forgedhallpass

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run the integration tests on all major operating systems
4 participants
@LuitelSamikshya @ehsandeep @Mzack9999 @forgedhallpass