bug: fixed couple of bugs in the DSL functions #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the output signatures
Sort the output signatures. Lint: simplified the sorting.
Input number parameters are stored as float64 types, hence the type conversion should happen accordingly. Affected functions: * rand_int * wait_for * unix_time * rand_text_numeric Added tests for all functions. Related: #1261
Mzack9999
approved these changes
Dec 14, 2021
Handle cases when the optional input character set is an empty string. Affected methods: * rand_char * rand_base
Change rand_char to return a one character string, instead of the character code
…ted result numbers
Fixing linter issues.
ehsandeep
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: fixed couple of bugs in the DSL functions
Input number parameters are stored as float64 types, hence the type conversion should happen accordingly. Affected functions:
rand_intwait_forunix_timerand_text_numericAdded tests for all functions.
Related: #1261, but it does not (intentionally) solve it completely.