-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stop at first match for interactsh matchers #1417
Conversation
… interactsh-first-match-stop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, there is a whois test failing on macos - https://github.com/projectdiscovery/nuclei/runs/4593459674?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@parrasajad instead of having a global c.matched
value and tracking it for ignoring further interact event, I guess what we should do here is to prevent duplicated interactsh matches from same template if we have stop at first match attribute. If we apply this globally, no interactions will match even for other templates since the interactsh client is shared.
We can implement some sort of tracking logic in protocols/common/interactsh
for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Proposed changes
Extend
stop at first match
support to interactsh matchersExample template (from issue)
Checklist