Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for ignore file path override if custom config file is used #1441

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Adding support for ignore file path override if custom config file is used #1441

merged 2 commits into from
Jan 10, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Dec 31, 2021 •
edited
Loading

Proposed changes

If a custom config file is specified, this PR attempts to load .nuclei-ignore from the same folder.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Dec 31, 2021
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 31, 2021
@Mzack9999 Mzack9999 linked an issue Dec 31, 2021 that may be closed by this pull request
Make the overriden config path applicable to the .nuclei-ignore file as well #1154
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Dec 31, 2021
ehsandeep
ehsandeep previously requested changes Jan 9, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of missing .nuclei-ignore file in the custom config folder location, we can use the original .nuclei-ignore from the default location to avoid running the default excluded templates.

[ERR] Could not read nuclei-ignore file: open test/.nuclei-ignore: no such file or directory

@ehsandeep ehsandeep added Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 9, 2022
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Revision Needed Submitter of PR needs to revise the PR related to the issue. labels Jan 10, 2022
@ehsandeep ehsandeep merged commit 0635b9e into dev Jan 10, 2022
@ehsandeep ehsandeep deleted the issue-1154-nuclei-ignore-with-overridden-path branch January 10, 2022 09:18
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the overriden config path applicable to the .nuclei-ignore file as well
3 participants
@Mzack9999 @ehsandeep @Ice3man543