-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run remote template #1472
Conversation
* Add remote-template-domain config only flag to specify allowed domain list to load remote templates from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires go mod
update to fetch changes from goflags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a sensitive feature that can lead to potential vulnerabilities if not implemented correctly, it is important to have extensive tests with multiple scenarios, especially negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently RemoteTemplateDomainList
validation cheks only when loading single remote template with YAML extension and not when loading remote template with list input, we need to enforce the validation for 2nd input as well.
Proposed changes
Checklist