Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run remote template #1472

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Add support to run remote template #1472

merged 6 commits into from
Jan 27, 2022

Conversation

parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Jan 12, 2022

  • Add remote-template-domain config only flag to specify allowed domain list to load remote templates from

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

* Add remote-template-domain config only flag to specify allowed domain list to load remote templates from
@ehsandeep ehsandeep linked an issue Jan 12, 2022 that may be closed by this pull request
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires go mod update to fetch changes from goflags

Copy link
Contributor

@forgedhallpass forgedhallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a sensitive feature that can lead to potential vulnerabilities if not implemented correctly, it is important to have extensive tests with multiple scenarios, especially negative.

v2/pkg/catalog/loader/remote_loader.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 19, 2022
@ehsandeep ehsandeep added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 20, 2022
v2/pkg/catalog/loader/remote_loader.go Outdated Show resolved Hide resolved
v2/pkg/catalog/loader/remote_loader.go Outdated Show resolved Hide resolved
v2/pkg/templates/compile.go Outdated Show resolved Hide resolved
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently RemoteTemplateDomainList validation cheks only when loading single remote template with YAML extension and not when loading remote template with list input, we need to enforce the validation for 2nd input as well.

@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 27, 2022
@ehsandeep ehsandeep merged commit 8566bc0 into dev Jan 27, 2022
@ehsandeep ehsandeep deleted the remote-templates branch January 27, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running remote hosted template
4 participants