Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for Debug http verb #1484

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Adding support for Debug http verb #1484

merged 1 commit into from
Jan 16, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 13, 2022 •
edited
Loading

Proposed changes

This PR supports the DEBUG HTTP verb for non-raw http requests.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Notes

I think validation for HTTP verbs should be removed since it's not consistent with the raw format that allows arbitrary values and prevents testing more extended HTTP-based protocols such as WebDAV (examples of used verbs COPY, LOCK, MKCOL, ...)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 13, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 13, 2022
@Mzack9999 Mzack9999 linked an issue Jan 13, 2022 that may be closed by this pull request
The DEBUG Http Method is disallowed with BaseURL based templates #1384
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 13, 2022
@ehsandeep ehsandeep merged commit 2ee27c8 into dev Jan 16, 2022
@ehsandeep ehsandeep deleted the issue-1384-debug-method branch January 16, 2022 11:35
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Ice3man543 Ice3man543 Ice3man543 approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The DEBUG Http Method is disallowed with BaseURL based templates
3 participants
@Mzack9999 @ehsandeep @Ice3man543