Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update validation logic to validate workflow templates and subtemplates #1489

Merged
merged 2 commits into from
Jan 18, 2022
Merged

update validation logic to validate workflow templates and subtemplates #1489

merged 2 commits into from
Jan 18, 2022

Conversation

parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Jan 14, 2022 •
edited by Mzack9999
Loading

Proposed changes

The PR implements validation logic for templates/subtemplates within a workflow.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@parrasajad parrasajad linked an issue Jan 14, 2022 that may be closed by this pull request
Workflow validation marked as valid upon failure #1451
Closed
@Mzack9999 Mzack9999 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Jan 14, 2022
Mzack9999
Mzack9999 previously requested changes Jan 14, 2022
View reviewed changes
v2/pkg/catalog/loader/loader.go Outdated Show resolved Hide resolved
v2/pkg/catalog/loader/loader.go Outdated Show resolved Hide resolved
v2/pkg/catalog/loader/loader.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 dismissed their stale review January 18, 2022 11:24

changes are implemented

@ehsandeep ehsandeep removed the request for review from Ice3man543 January 18, 2022 15:56
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 18, 2022
@ehsandeep ehsandeep merged commit eb6a1b2 into dev Jan 18, 2022
@ehsandeep ehsandeep deleted the workflow-validation-fix branch January 18, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@parrasajad parrasajad

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow validation marked as valid upon failure
3 participants
@parrasajad @ehsandeep @Mzack9999