Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending http variables list with dns generated variables #1490

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 14, 2022

Proposed changes

This PR extends the list of variables for HTTP protocol with DNS ones generated from the domain name (ref #1174)

  • {{FQDN}} - Fully qualified domain name (already supported)
  • {{RDN}} - Root domain name
  • {{DN}} - Domain name
  • {{TLD}} - Toplevel domain
  • {{SD}} - Sub domain

and here is how it can be interpreted using an example as www.projectdiscovery.io

Global Variable Example value
{{FQDN}} www.projectdiscovery.io
{{RDN}} projectdiscovery.io
{{DN}} projectdiscovery
{{TLD}} io
{{SD}} www

Note:

  • {{SD}} - subdomains include lower-level subdomains as well, for example in the case of test.abc.domain.com, {{SD}} will be evaluated as test.abc

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Jan 14, 2022
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 14, 2022
@Mzack9999 Mzack9999 linked an issue Jan 14, 2022 that may be closed by this pull request
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 14, 2022
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit 562c89c into dev Jan 16, 2022
@ehsandeep ehsandeep deleted the issue-1433-additional-http-vars branch January 16, 2022 11:44
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More global variables for HTTP protocol
3 participants