Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing race-requests block on curl generation command #1500

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Fixing race-requests block on curl generation command #1500

merged 2 commits into from
Jan 18, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 17, 2022 •
edited
Loading

Proposed changes

This PR fixes the issue reported in #1471 caused by the curl command generation logic attempting to read from the request body, which in case of race requests uses an open-gate mechanism to act synchronously

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 17, 2022
@Mzack9999 Mzack9999 self-assigned this Jan 17, 2022
@Mzack9999 Mzack9999 linked an issue Jan 17, 2022 that may be closed by this pull request
[issue] bug in race condition modules #1471
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 17, 2022
@ehsandeep ehsandeep merged commit 3afc2f4 into dev Jan 18, 2022
@ehsandeep ehsandeep deleted the issue-1471-race-conditions branch January 18, 2022 16:02
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[issue] bug in race condition modules
2 participants
@Mzack9999 @ehsandeep