Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strip default http/https ports from Host header #1506

Merged
merged 2 commits into from
Jan 20, 2022
Merged

fix: strip default http/https ports from Host header #1506

merged 2 commits into from
Jan 20, 2022

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Jan 17, 2022 •
edited by ehsandeep
Loading

Proposed changes

Closes #1505

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 self-assigned this Jan 17, 2022
@Ice3man543 Ice3man543 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jan 17, 2022
@Ice3man543 Ice3man543 linked an issue Jan 17, 2022 that may be closed by this pull request
nuclei specifices :80 and :443 in the Host header, causing false negatives #1505
Closed
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 20, 2022
@ehsandeep ehsandeep added Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: Completed Nothing further to be done with this issue. Awaiting to be closed. labels Jan 20, 2022
@ehsandeep ehsandeep merged commit 3091e70 into dev Jan 20, 2022
@ehsandeep ehsandeep deleted the default-port-fix branch January 20, 2022 12:20
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nuclei specifices :80 and :443 in the Host header, causing false negatives
3 participants
@Ice3man543 @ehsandeep @Mzack9999