Implementing lexer with runtime expression validation #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
Type: Enhancement
This was
linked to
issues
Jan 19, 2022
Mzack9999
added
Status: Review Needed
4 tasks
ehsandeep
approved these changes
Jan 25, 2022
Ice3man543
approved these changes
Jan 26, 2022
| // maxIterations to avoid infinite loop | ||
| const maxIterations = 250 | ||
|
|
||
| func findExpressions(data, OpenMarker, CloseMarker string, functions map[string]govaluate.ExpressionFunction) []string { |
There was a problem hiding this comment.
This method is complex enough, so it could use an extensive unit test.
forgedhallpass
approved these changes
Jan 26, 2022
ehsandeep
added
Status: Completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR refactors the expression identification logic with a pseudo-lexer that performs runtime validation of potential matches. Expressions containing placeholders and/or helper functions are evaluated (eg
{{a+b}}, whereas literals containing only base types are not (eg{{'a' + 'b'}}).Checklist
Closes https://github.com/projectdiscovery/jira-backlogs/issues/133