Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed network response error + timeout handling #1663

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Fixed network response error + timeout handling #1663

merged 2 commits into from
Mar 2, 2022

Conversation

Ice3man543
Copy link
Member

@Ice3man543 Ice3man543 commented Mar 1, 2022 •
edited by ehsandeep
Loading

Proposed changes

Closes #1609

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ice3man543 Ice3man543 self-assigned this Mar 1, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 March 1, 2022 17:35
@ehsandeep ehsandeep linked an issue Mar 1, 2022 that may be closed by this pull request
When processing network requests, if read block more than 1024*8,will be error. #1609
Closed
@ehsandeep ehsandeep mentioned this pull request Mar 1, 2022
Merged
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@ehsandeep ehsandeep merged commit db8f8b4 into dev Mar 2, 2022
@ehsandeep ehsandeep deleted the network-fix branch March 2, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@Ice3man543 Ice3man543

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When processing network requests, if read block more than 1024*8,will be error.
3 participants
@Ice3man543 @Mzack9999 @ehsandeep