Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom headers from file #1756

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add support for custom headers from file #1756

merged 2 commits into from
Mar 31, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Mar 23, 2022 •
edited
Loading

Proposed changes

This PR add support for reading custom headers from file.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Notes

Depends on:

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Mar 23, 2022
@Mzack9999 Mzack9999 self-assigned this Mar 23, 2022
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 23, 2022
@Mzack9999 Mzack9999 linked an issue Mar 23, 2022 that may be closed by this pull request
File input support for header flag #1730
Closed
@ehsandeep ehsandeep merged commit e1efa26 into dev Mar 31, 2022
@ehsandeep ehsandeep deleted the issue-1730-header-flags branch March 31, 2022 20:08
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File input support for header flag
2 participants
@Mzack9999 @ehsandeep