Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizing special chars in markdown file paths #1758

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

Mzack9999
Copy link
Member

Proposed changes

This PR replaces ? with _ in markdown filename export

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 24, 2022
@Mzack9999 Mzack9999 self-assigned this Mar 24, 2022
@Mzack9999 Mzack9999 linked an issue Mar 24, 2022 that may be closed by this pull request
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Mar 24, 2022
@ehsandeep ehsandeep requested a review from sullo March 29, 2022 19:34
@sullo
Copy link
Contributor

sullo commented Apr 1, 2022

Having a further thought, I'd recommend we replace the following as they can be problematic on both Win/*nix:
/ > | : ; * > " '

I think this will cover any characters in a file name which could be problematic for a shell to manipulate them without adding quotes.

Also, :space: can be considered as well since it's annoying :)

Windows has more restrictions, but I don't think we need to account for every possible thing (e.g., "CON").

@ehsandeep ehsandeep removed the request for review from sullo April 6, 2022 09:29
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Apr 6, 2022
@ehsandeep ehsandeep merged commit e510bc2 into dev Apr 6, 2022
@ehsandeep ehsandeep deleted the issue-1714-path-with-special-chars branch April 6, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

special characters in file names
3 participants