New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for digest authentication #1811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
added
the
Type: Enhancement
Most issues will probably ask for additions or changes.
label
Apr 5, 2022
Mzack9999
added
the
Status: In Progress
This issue is being worked on, and has someone assigned.
label
Apr 5, 2022
Mzack9999
added
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
and removed
Status: In Progress
This issue is being worked on, and has someone assigned.
labels
Apr 5, 2022
ehsandeep
requested changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GET /digest-auth/auth/user/passwd/test HTTP/1.1
Host: httpbin.org
User-Agent: Go-http-client/1.1
Authorization: Digest username="user", realm="me@kennethreitz.com", nonce="29e379f905327a31b79c022b35ee302a", uri="/digest-auth/auth/user/passwd/test", response="505c202f0680d37bbe5aec9919355e90", cnonce="662f62d9ac36ddb099fe8a3b14a92670", opaque="f151368fe26ba4e439be9f91e4890478", qop=auth, nc=00000001
Accept-Encoding: gzip, deflate
Connection: close
Custom or Random User-Agent is considered if defined in the template.
ehsandeep
added
Status: Revision Needed
Submitter of PR needs to revise the PR related to the issue.
and removed
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
labels
Apr 14, 2022
ehsandeep
added
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
and removed
Status: Revision Needed
Submitter of PR needs to revise the PR related to the issue.
labels
Apr 14, 2022
ehsandeep
approved these changes
Apr 14, 2022
Ice3man543
approved these changes
Apr 15, 2022
ehsandeep
added
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
and removed
Status: Review Needed
The issue has a PR attached to it which needs to be reviewed
labels
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
Type: Enhancement
Most issues will probably ask for additions or changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for HTTP Digest Authentication via the new template settings
digest-username
anddigest-password
Checklist
Notes
Reproduction steps