Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving body dump logic for HTTP requests #1839

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Improving body dump logic for HTTP requests #1839

merged 1 commit into from
Apr 13, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Apr 12, 2022 •
edited
Loading

Proposed changes

This PR improves the body dump logic by removing the content-length header before passing the HTTP request to the standard dump function

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Apr 12, 2022
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 12, 2022
@Mzack9999 Mzack9999 linked an issue Apr 12, 2022 that may be closed by this pull request
Unable to scan continuously, it will get stuck #1833
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Apr 12, 2022
@ehsandeep ehsandeep merged commit 51bca65 into dev Apr 13, 2022
@ehsandeep ehsandeep deleted the issue-1833-scan-bug branch April 13, 2022 11:14
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Apr 13, 2022
@ehsandeep ehsandeep mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to scan continuously, it will get stuck
2 participants
@Mzack9999 @ehsandeep