Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing nil crash on json stats print #1853

Merged
merged 1 commit into from Apr 15, 2022
Merged

Fixing nil crash on json stats print #1853

merged 1 commit into from Apr 15, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Apr 15, 2022 •
edited

Proposed changes

This PR addresses the nil crash described in #1852

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Todo

  • Investigate why the -json flag used with -stats causes the progress.printCallbackJSON to be invoked before progress.Init

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 15, 2022
@Mzack9999 Mzack9999 self-assigned this Apr 15, 2022
@Mzack9999 Mzack9999 linked an issue Apr 15, 2022 that may be closed by this pull request
panic: interface conversion: interface {} is nil, not time.Time #1852
Closed
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Apr 15, 2022
@ehsandeep ehsandeep merged commit 4cbf7ea into dev Apr 15, 2022
@ehsandeep ehsandeep deleted the issue-1852-nil-crash branch April 15, 2022 18:01
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: interface conversion: interface {} is nil, not time.Time
2 participants
@Mzack9999 @ehsandeep