Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for dsl extractors #1873

Merged
merged 1 commit into from
Apr 21, 2022
Merged

adding support for dsl extractors #1873

merged 1 commit into from
Apr 21, 2022

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Apr 20, 2022

Proposed changes

This PR adds support for DSL extractors

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

How to reproduce

Example template:

id: example

info:
  name: example
  author: example
  severity: info
  description: omfp
  tags: info

requests:
  - raw:
      - |
        GET / HTTP/1.1
        Host: {{Hostname}}

    extractors:
      - type: dsl
        dsl:
          - "len(body)"

Execution:

$ go run . -duc -no-interactsh -t target-length.yaml -u https://192.168.1.1

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   2.6.8

                projectdiscovery.io

[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[INF] Using Nuclei Engine 2.6.8 (outdated)
[INF] Using Nuclei Templates 8.9.4 (latest)
[INF] Templates added in last update: 20
[INF] Templates loaded for scan: 1
[2022-04-20 11:34:01] [example] [http] [info] https://192.168.1.1/ [7313]

Notes

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Apr 20, 2022
@Mzack9999 Mzack9999 self-assigned this Apr 20, 2022
@Mzack9999 Mzack9999 linked an issue Apr 20, 2022 that may be closed by this pull request
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Apr 20, 2022
Copy link
Member

@Ice3man543 Ice3man543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@forgedhallpass
Copy link
Contributor

@Mzack9999 great addition, but please don't forget to update the documentation, and link the changes to this PR.

@ehsandeep ehsandeep merged commit 4573c4e into dev Apr 21, 2022
@ehsandeep ehsandeep deleted the issue-1565-dsl-extractors branch April 21, 2022 11:34
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSL extractors to extract response effective size
4 participants