build workflow update #2911

ehsandeep · 2022-11-26T13:33:32Z

Proposed changes

Pull request is created against the dev branch
All checks passed (lint, unit/integration/regression tests etc.) with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

.github/workflows/build-test.yml

tarunKoyalwar · 2022-11-26T15:23:37Z

If we enable caching build outputs and dependencies installation time in gh action will be < 10-20 sec

Mzack9999 · 2022-11-28T06:44:29Z

~~@tarunKoyalwar, this is a very good suggestion. Anyway, wouldn't this potentially leave the cache in a dirty state in case of a crash or random failures to complete the deps building process?~~ tracked at https://github.com/projectdiscovery/pd-bot/issues/5

build workflow update

f4fcf6a

ehsandeep marked this pull request as draft November 26, 2022 13:33

ehsandeep marked this pull request as ready for review November 26, 2022 14:11

ehsandeep requested review from Mzack9999 and tarunKoyalwar November 26, 2022 14:11

tarunKoyalwar reviewed Nov 26, 2022

View reviewed changes

.github/workflows/build-test.yml Show resolved Hide resolved

Mzack9999 approved these changes Nov 28, 2022

View reviewed changes

Mzack9999 requested a review from tarunKoyalwar November 28, 2022 10:10

tarunKoyalwar approved these changes Nov 28, 2022

View reviewed changes

ehsandeep merged commit 2b7b764 into dev Nov 28, 2022

ehsandeep deleted the build-workflow-update branch November 28, 2022 22:50