-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds scan strategy #3075
adds scan strategy #3075
Conversation
Flag UsageUser should select strategy based on targets . Each strategy has its own cons and pros
Note:the only criteria is target count . and whatever the scan strategy is selected nuclei performance will depend on below two parameters
whatever the scan type is |
Integration Test fails due to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I'm proposing the following follow ups and missing TODOs:
- Update docs with adds scan strategy #3075 (comment)
Create the following follow up tickets:
- Implementing
auto
strategy selection - Tune
http.Transport
and Network settings for single-host scan (ideally no HTTP connection should be closed if RFC-compliant)
@tarunKoyalwar useful addition 🎉 @Mzack9999 merging this PR as requested changes have been updated and fail tests are the result of another known issue in GH CI - #2969 |
Proposed changes
scan-strategy
flag to nucleihost-spray
all templates are iterated over each hosttemplate-spray
all hosts are iterated over each templateauto
. [This is only a placeholder oftemplate-spray
for now] strategy should be selected based on given parameters and inputs.Before this PR
template-spray
strategy was used and current default istemplate-spray
closes #3065
Checklist