Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extending request/response hijacking with native calls #3091

Merged
merged 2 commits into from
Jan 5, 2023
Merged

extending request/response hijacking with native calls #3091

merged 2 commits into from
Jan 5, 2023

Conversation

Mzack9999
Copy link
Member

Proposed changes

This PR improves headless request/response hijacking through chrome native api (reuses katana hijack implementation)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 27, 2022
@Mzack9999 Mzack9999 self-assigned this Dec 27, 2022
@Mzack9999 Mzack9999 linked an issue Dec 27, 2022 that may be closed by this pull request
File action does not work via Browser Headless scripts #2764
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 27, 2022
View reviewed changes
v2/cmd/integration-test/headless.go
return
}

_, _ = w.Write(content)

Check warning

Code scanning / CodeQL

Reflected cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
@tarunKoyalwar
Copy link
Member

@Mzack9999 , currently errors like errElementDidNotAppear are of type string wouldn't it be better to make them of type error?? . and they seem to be not exported out of package

@Mzack9999
Copy link
Member Author

@tarunKoyalwar good point. This is common across all the codebases as the error string is used within errors.Wrap. I think this can be tracked in a follow-up issue, with a general refactor of error handling using errorutils

@ehsandeep ehsandeep merged commit a96f764 into dev Jan 5, 2023
@ehsandeep ehsandeep deleted the issue-2764-headless-file-upload branch January 5, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File action does not work via Browser Headless scripts
3 participants
@Mzack9999 @tarunKoyalwar @ehsandeep