Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing host skipping error #3143

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Fixing host skipping error #3143

merged 2 commits into from
Jan 3, 2023

Conversation

ehsandeep
Copy link
Member

@ehsandeep ehsandeep commented Jan 3, 2023 •
edited
Loading

Proposed changes

  1. context deadline exceeded is not reliable to use against the error counter to skip the host as it can be generated for multiple engines.
  2. could not connect to any address found for host is not reliable as currently it's expected to get this error while running a network template with invalid port input.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ehsandeep ehsandeep linked an issue Jan 3, 2023 that may be closed by this pull request
nuclei skips all targets #3142
Closed
@ehsandeep ehsandeep merged commit 2d7948a into dev Jan 3, 2023
@ehsandeep ehsandeep deleted the fixing-host-skipping-error branch January 3, 2023 19:13
@ehsandeep ehsandeep mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nuclei skips all targets
1 participant
@ehsandeep