Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending advanced filtering #3146

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Extending advanced filtering #3146

merged 4 commits into from
Jan 5, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jan 4, 2023

Proposed changes

This PR implements metadata addition as described in #2826. The new fields can be used as follows:

nuclei -tc protocol=='dns'
nuclei -tc contains(http_methods,'GET')
nuclei -tc len(bodies)>0
nuclei -tc contains(matcher_types,'word')
nuclei -tc contains(extractor_types,'regex')
nuclei -tc contains(description,'wordpress')

Notes

Docs update tracked at projectdiscovery/nuclei-docs#104

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 4, 2023
@Mzack9999 Mzack9999 self-assigned this Jan 4, 2023
@Mzack9999 Mzack9999 marked this pull request as draft January 4, 2023 08:47
@Mzack9999 Mzack9999 linked an issue Jan 4, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 marked this pull request as ready for review January 4, 2023 08:56
@Mzack9999 Mzack9999 changed the title Issue 2826 advanced filtering Extending advanced filtering Jan 4, 2023
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably missed in #2374. Do you think we can make this case insensitive? @Mzack9999

$./nuclei -tc "contains(description,'wordpress')" -tl -silent | wc
       7
$./nuclei -tc "contains(description,'WordPress')" -tl -silent | wc
     376

@ehsandeep ehsandeep merged commit 8beb6b0 into dev Jan 5, 2023
@ehsandeep ehsandeep deleted the issue-2826-advanced-filtering branch January 5, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending the advanced template filtering feature
3 participants