Support for multiple fingerprints in single template #25 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow @NkxxkN, this is really amazing stuff. I haven't though of matchers this way. Thanks for the work you've put into this. Let me do a review and we'll make sure to merge this ASAP! |
Ice3man543
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple fingerprints in single template
Implementation for multiple matchers in template was already here but
runner.sendRequestreturned after first matcher fail. This PR makes sure that all matchers are checked.Adding an optional name attribute to matchers to uniquely identify which matcher is used while printing result.
This is very useful in order to reduce the noise of multiple requests when it could be achieved with one:
Examples
Issue
https://github.com/projectdiscovery/nuclei//issues/25