Added clustering support for TLS templates #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ice3man543
added
the
Status: Review Needed
tarunKoyalwar
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
$ ./nuclei -t ~/nuclei-templates/ssl -u scanme.sh
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 8
[INF] Targets loaded for scan: 1
[INF] Templates clustered: 7 (Reduced 6 Requests)
[mismatched-ssl] [ssl] [low] scanme.sh
[self-signed-ssl] [ssl] [low] scanme.sh
[ssl-issuer] [ssl] [low] scanme.sh [pd]
[tls-version] [ssl] [low] scanme.sh [tls13]
[deprecated-tls] [ssl] [info] scanme.sh [tls10]
[deprecated-tls] [ssl] [info] scanme.sh [tls11]$ ./nuclei -t ~/nuclei-templates/ssl -u scanme.sh -disable-clustering
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 8
[INF] Targets loaded for scan: 1
[tls-version] [ssl] [info] scanme.sh [tls13]
[mismatched-ssl] [ssl] [low] scanme.sh
[deprecated-tls] [ssl] [info] scanme.sh [tls10]
[ssl-issuer] [ssl] [info] scanme.sh [pd]
[deprecated-tls] [ssl] [info] scanme.sh [tls11]
[self-signed-ssl] [ssl] [low] scanme.sh
ehsandeep
requested changes
Jan 17, 2023
There was a problem hiding this comment.
cat h1.txt | ./nuclei -pt ssl
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 8
[INF] Targets loaded for scan: 21
[INF] Templates clustered: 7 (Reduced 126 Requests)
[ssl-issuer] [ssl] [medium] docs.hackerone.com [Let's Encrypt]
[ssl-dns-names] [ssl] [medium] docs.hackerone.com [docs.hackerone.com]
[tls-version] [ssl] [medium] docs.hackerone.com [tls13]
[ssl-issuer] [ssl] [medium] mta-sts.hackerone.com [Let's Encrypt]
[ssl-dns-names] [ssl] [medium] mta-sts.hackerone.com [mta-sts.hackerone.com]
[tls-version] [ssl] [medium] mta-sts.hackerone.com [tls13]
[ssl-issuer] [ssl] [medium] mta-sts.forwarding.hackerone.com [Let's Encrypt]
[ssl-dns-names] [ssl] [medium] mta-sts.forwarding.hackerone.com [mta-sts.forwarding.hackerone.com]
[tls-version] [ssl] [medium] mta-sts.forwarding.hackerone.com [tls13]Severity information is being wrongly populated randomly.
ehsandeep
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
echo 66.96.146.129 | ./nuclei -id tls-version,ssl-issuer
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.7
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.7 (latest)
[INF] Using Nuclei Templates 9.3.4 (latest)
[INF] Templates added in last update: 15
[INF] Templates loaded for scan: 2
[INF] Targets loaded for scan: 1
[INF] Templates clustered: 2 (Reduced 1 Requests)
[tls-version] [ssl] [info] 66.96.146.129 [tls12]
[ssl-issuer] [ssl] [info] 66.96.146.129 [Sectigo Limited]Results into single server hello, instead two (running with -dc option)
ehsandeep
removed
the
Status: Review Needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #2440
./nuclei -t ./report -u docs.hackerone.com:443 __ _ ____ __ _______/ /__ (_) / __ \/ / / / ___/ / _ \/ / / / / / /_/ / /__/ / __/ / /_/ /_/\__,_/\___/_/\___/_/ v2.8.7 projectdiscovery.io [INF] Using Nuclei Engine 2.8.7 (latest) [INF] Using Nuclei Templates 9.3.4 (latest) [INF] Templates added in last update: 15 [INF] Templates loaded for scan: 2 [INF] Targets loaded for scan: 1 [INF] Templates clustered: 2 (Reduced 1 Requests) [ssl-issuer] [ssl] [info] docs.hackerone.com [Let's Encrypt]Default run leads to reduction of 6 requests per public templates.
Checklist