New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix make http request inconsistencies #3243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example Run $ go run . -id CVE-2022-35405 -v -u scanme.sh
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.8
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.8 (latest)
[INF] Using Nuclei Templates 9.3.6 (latest)
[INF] Templates added in last update: 30
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 1
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[VER] [CVE-2022-35405] Sent HTTP request to https://scanme.sh/xmlrpc
[WRN] [CVE-2022-35405] Could not execute request for scanme.sh: POST https://scanme.sh:8282/xmlrpc giving up after 2 attempts: Post "https://scanme.sh:8282/xmlrpc": dial tcp [2400:6180:0:d0::91:1001]:8282: connect: connection refused
[WRN] [CVE-2022-35405] Could not execute request for scanme.sh: POST https://scanme.sh:9292/xmlrpc giving up after 2 attempts: Post "https://scanme.sh:9292/xmlrpc": dial tcp [2400:6180:0:d0::91:1001]:9292: connect: connection refused
[WRN] [CVE-2022-35405] Could not execute request for scanme.sh: POST https://scanme.sh:7272/xmlrpc giving up after 2 attempts: Post "https://scanme.sh:7272/xmlrpc": dial tcp [2400:6180:0:d0::91:1001]:7272: connect: connection refused
[INF] No results found. Better luck next time! |
Things to Note from current state
For Raw Requests
For Non-Raw Requests (Specifically
|
echo "scanme.sh/?admin=true" | go run . -id "CVE-2018-16670" -v
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.8
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.8 (latest)
[INF] Using Nuclei Templates 9.3.6 (latest)
[INF] Templates added in last update: 30
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 1
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[VER] [CVE-2018-16670] Sent HTTP request to https://scanme.sh/services/user/values.xml?admin=true&var=STATUS
[INF] No results found. Better luck next time!
|
Mzack9999
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes
Mzack9999
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Implementation: lgtm
- Flagging potential issue related to process exit code to verify
merge dev to fix failing gh actions and build
2 tasks
Mzack9999
approved these changes
Feb 1, 2023
ehsandeep
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make
HTTP protocol request logic was centred towards{{BaseURL}}
(automerge params etc) which caused inconsistencies when templates used{{RootURL}}
or any other variable inPath
section of the template.debug.sh
for debugging integration testsMake
(http protocol)trailing slash
logic (uses a proper regex to match) + added unit testcloses #3242
Checklist