Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publish docs #3296

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix publish docs #3296

merged 2 commits into from
Feb 9, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Feb 9, 2023

Proposed changes

Note that we explicitly specify ${{ github.head_ref }} in the checkout Action. This is required in order to work with the pull_request event (or any other non-push event).

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar tarunKoyalwar marked this pull request as draft February 9, 2023 13:32
@tarunKoyalwar tarunKoyalwar self-assigned this Feb 9, 2023
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review February 9, 2023 13:37
@tarunKoyalwar tarunKoyalwar added the github_actions Pull requests that update Github_actions code label Feb 9, 2023
@ehsandeep ehsandeep merged commit a62e57f into dev Feb 9, 2023
@ehsandeep ehsandeep deleted the fix-publish-docs branch February 9, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants