-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2987 fuzz options #3355
Issue 2987 fuzz options #3355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamRasal, Can we add tests for this option as we have for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I couldn't find CLI override tests for other parameters such as AttackType
. @ehsandeep, did you mean to implement functional tests?
@ehsandeep @Mzack9999 not sure functional tests but I think we can implement this in integration_test since it has option to pass extra cli args |
Agree with @tarunKoyalwar, I'll add the integration test to validate override fuzzing options. |
- validate the command line overriding type and mode for fuzzing
router.GET("/", func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) { | ||
w.Header().Set("Content-Type", "text/html") | ||
value := r.URL.Query().Get("id") | ||
fmt.Fprintf(w, "This is test matcher text: %v", value) |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting
router.GET("/", func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) { | ||
w.Header().Set("Content-Type", "text/html") | ||
value := r.URL.Query().Get("id") | ||
fmt.Fprintf(w, "This is test matcher text: %v", value) |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting
router.GET("/", func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) { | ||
w.Header().Set("Content-Type", "text/html") | ||
value := r.URL.Query().Get("id") | ||
fmt.Fprintf(w, "This is test matcher text: %v", value) |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting
Override type and mode using flag: