-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3350 matcher condition or not work #3397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before$ nuclei -u scanme.sh -t http/default-matcher-condition.yaml 1 ↵
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.9
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.9 (latest)
[INF] Using Nuclei Templates 9.3.8 (latest)
[INF] Templates added in last update: 656
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 1
[INF] Running httpx on input host
[INF] Found 1 URL from httpx
[INF] Using Interactsh Server: oast.fun
[INF] No results found. Better luck next time! Integration Test result covering both cases$ ./integration-test -protocol http -template matcher-condition 130 ↵
./nuclei -t http/default-matcher-condition.yaml -target http://127.0.0.1:56674/interactsh -duc -debug
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.9
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.9 (latest)
[INF] Using Nuclei Templates 9.3.8 (latest)
[INF] Templates added in last update: 656
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 1
[INF] Using Interactsh Server: oast.fun
...redacted...
[default-matcher-condition:word-1] [http] [info] http://127.0.0.1:56674/interactsh/?action=curltest&url=cg4ef9a401gd2u5i0uv058cbbaqbq6nkr.oast.fun
./nuclei -t http/default-matcher-condition.yaml -target http://127.0.0.1:56674/status -duc -debug
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.8.9
projectdiscovery.io
[INF] Using Nuclei Engine 2.8.9 (latest)
[INF] Using Nuclei Templates 9.3.8 (latest)
[INF] Templates added in last update: 656
[INF] Templates loaded for scan: 1
[INF] Targets loaded for scan: 1
[INF] Using Interactsh Server: oast.pro
...redacted....
[default-matcher-condition:status-2] [http] [info] http://127.0.0.1:56674/status/?action=curltest&url=cg4efaq401gd2uti0uv069oj3dw5efeqo.oast.pro
|
TODO
|
// Server endpoint where only interactsh matcher is successful and status code is not 200 | ||
router.GET("/interactsh/", func(w http.ResponseWriter, r *http.Request, _ httprouter.Params) { | ||
value := r.URL.Query().Get("url") | ||
if value != "" { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in network request
The [URL](1) of this request depends on a [user-provided value](2).
Follow up ticket for build fail - #3423 |
|
tarunKoyalwar
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
ehsandeep
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist