Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix aws s3 bucket catalog path mismatch #3474

Merged
merged 2 commits into from
Mar 28, 2023
Merged

fix aws s3 bucket catalog path mismatch #3474

merged 2 commits into from
Mar 28, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Mar 27, 2023 •
edited

Proposed Changes

  • using filepath when loading templates from s3 buckets causes path mismatch in windows since filepath is os specific and s3 paths /URI need / .
  • This pr uses path for filtering s3 templates instead of filepath
  • closes Failing TestCatalog_ResolvePath test #3467

@tarunKoyalwar tarunKoyalwar changed the base branch from main to dev March 27, 2023 15:54
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:go. As part of the setup process, we have scanned this repository and found 23 existing alerts. Please check the repository Security tab to see all alerts.

@tarunKoyalwar tarunKoyalwar changed the title issue 3467 fix catalog test fix aws s3 bucket catalog path mismatch Mar 28, 2023
@tarunKoyalwar tarunKoyalwar self-assigned this Mar 28, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Mar 28, 2023 that may be closed by this pull request
Failing TestCatalog_ResolvePath test #3467
Closed
@Mzack9999 Mzack9999 merged commit 42660be into dev Mar 28, 2023
@Mzack9999 Mzack9999 deleted the issue-3467-fix-catalog-test branch March 28, 2023 20:51
@RamanaReddy0M RamanaReddy0M mentioned this pull request Apr 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing TestCatalog_ResolvePath test
3 participants
@tarunKoyalwar @ehsandeep @Mzack9999