-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payload in dns protocol #3632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also check command line overriding a payload variable
ehsandeep
requested changes
May 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- matched at to include complete dns name in json/cli output
- removed trailing dot in dns name output
2 tasks
ehsandeep
requested changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Minor issue with stats calculation with payloads.
- debug / verbose mode should also reflect queried dns name instead of input.
echo google.com | ./nuclei -t test.yaml -stats -v
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.3-dev
projectdiscovery.io
[INF] Current nuclei version: v2.9.3-dev (development)
[INF] Current nuclei-templates version: v9.4.3 (latest)
[INF] New templates added in latest release: 55
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
[VER] [dns-attack] Sent DNS request to google.com.
[VER] [dns-attack] Sent DNS request to google.com.
[VER] [dns-attack] Sent DNS request to google.com.
[VER] [dns-attack] Sent DNS request to google.com.
[VER] [dns-attack] Sent DNS request to google.com.
[0:00:05] | Templates: 1 | Hosts: 1 | RPS: 1 | Matched: 0 | Errors: 3 | Requests: 8/1 (800%)
- Update verbose output to print question - Update dns requests Requests function to consider payload data
❯ ./nuclei -u https://google.com -t templates/dns-payload.yaml -stats -v
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.3-dev
projectdiscovery.io
[INF] Current nuclei version: v2.9.3-dev (outdated)
[INF] Current nuclei-templates version: 9.4.3 (latest)
[INF] New templates added in latest release: 55
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
[VER] [dns-attack] Sent DNS request to one.google.com
[dns-attack] [dns] [info] one.google.com [142.250.183.14]
[VER] [dns-attack] Sent DNS request to docs.google.com
[dns-attack] [dns] [info] docs.google.com [142.251.42.14]
[VER] [dns-attack] Sent DNS request to drive.google.com
[dns-attack] [dns] [info] drive.google.com [142.250.192.110]
[0:00:00] | Templates: 1 | Hosts: 1 | RPS: 51 | Matched: 3 | Errors: 0 | Requests: 3/3 (100%) |
tarunKoyalwar
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
$ ./nuclei -u google.com -t ~/test-templates/dnspayload.yaml
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ v2.9.3-dev
projectdiscovery.io
[INF] Current nuclei version: v2.9.3-dev (outdated)
[INF] Current nuclei-templates version: v9.4.3 (latest)
[INF] New templates added in latest release: 18
[INF] Templates loaded for current scan: 1
[INF] Targets loaded for current scan: 1
[dns-attack] [dns] [info] one.google.com [142.251.42.110]
[dns-attack] [dns] [info] docs.google.com [142.250.183.174]
[dns-attack] [dns] [info] drive.google.com [142.250.183.206]
ehsandeep
approved these changes
May 10, 2023
ehsandeep
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template
command
Checklist