Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default resp size to options #4050

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Adding default resp size to options #4050

merged 1 commit into from
Aug 14, 2023

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Aug 14, 2023

Proposed changes

Closes #3988

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Example

With the code snippet in the linked issue:

$ cat test.go
...go
outputWriter := testutils.NewMockOutputWriter()
outputWriter.WriteCallback = func(event *output.ResultEvent) {
	fmt.Printf("\n\n\nGot Result: %+v\n", event.Response)
}
...
$ go run .
[INF] Using Interactsh Server: oast.site

Got Result: HTTP/1.1 200 OK
Connection: close
Content-Length: 2
Content-Type: text/plain; charset=utf-8
Date: Mon, 14 Aug 2023 09:14:05 GMT

ok

@Mzack9999 Mzack9999 self-assigned this Aug 14, 2023
@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 14, 2023
@Mzack9999 Mzack9999 linked an issue Aug 14, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 marked this pull request as ready for review August 14, 2023 09:12
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

tracking issue of syncing defaults between SDK and goflags default in new SDK issue #4054

@ehsandeep ehsandeep merged commit d07c273 into dev Aug 14, 2023
11 checks passed
@ehsandeep ehsandeep deleted the bugfix-3988-resp-size branch August 14, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Nuclei From Go Code,CAN NOT got Response
3 participants