-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate(remove): file write in extractor using to
#4565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunKoyalwar
changed the title
fix race-condition & oow in extracted file output
fix race-condition & out of bounds write while saving extracted values to file
Jan 2, 2024
dogancanbakir
approved these changes
Jan 4, 2024
Mzack9999
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - My observations:
- The
to:
option should probably be replaced with a deterministic output path as we do inhttpx
to organize request/response/screenshot and report in the output json the path to the file within a field - Multiple templates might point/access to the same file, probably this particular output mechanisms needs a redesign to simplify them as described above
tarunKoyalwar
changed the title
fix race-condition & out of bounds write while saving extracted values to file
deprecate(remove): file write in extractor using Jan 4, 2024
to
Mzack9999
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
salute to the 'save to file' feature
ehsandeep
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
to
in extractors to save extracted data to fileCaution
This is a breaking change and may break templates containing
to
field in extractorsSaving extracted values to file using
to
in extractors has been removed due to following reasonsnuclei -j
Note
Saving screenshot to file using
to
has been made with other filesystem restriction options (i.e-lfa
) keeping usability in mind. Now when saving screenshots outside of cwd (i.e parent / sibling directories)-lfa
will be required