Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network layer should not have forceful read #4737

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Mzack9999
Copy link
Member

Proposed changes

This PR makes network final read optional, since it's up to the application protocol level to define which interactions requires a final recv operation. All C2 templates and those based only on network variables are currently broken if the server doesn't send any data.

Closes #4518

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 self-assigned this Feb 6, 2024
@Mzack9999 Mzack9999 marked this pull request as ready for review February 7, 2024 07:19
@Mzack9999 Mzack9999 merged commit 7e108cd into dev Feb 7, 2024
12 checks passed
@Mzack9999 Mzack9999 deleted the bugfix-4518-optional-read branch February 7, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JARM Hash Issue : Nuclei not able to detect the hash
2 participants