Fix overriding the predefined ratelimiter by WithGlobalRateLimit #4884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I noticed that the
e.rateLimiter
set inWithGlobalRateLimit
was overwritten insdk_private.go
and the RPS was unlimited every time, so I fixed it.I ran
WithGlobalRateLimit(10, time.Second)
inexamples/simple/simple.go
to verify that the RPS is correctly below 10.Checklist