Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix v from Sarif exporters #4976

Merged
merged 1 commit into from Apr 3, 2024

Conversation

tibbon
Copy link
Contributor

@tibbon tibbon commented Apr 1, 2024

because: In config.Version there is already
a v prefix, such as v3.2.2.

Prior to this commit the versions were being
tagged as vv3.2.2

this commit: Removes the 'v' prefix from the
Sarif exporter in the ToolDetails for both
FullName and SemanticVersion.

Proposed changes

Removes the 'v' prefix from the
Sarif exporter in the ToolDetails for both
FullName and SemanticVersion.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

because: In config.Version there is already
a `v`` prefix, such as `v3.2.2``.

Prior to this commit the versions were being
tagged as `vv3.2.2`

this commit: Removes the 'v' prefix from the
Sarif exporter in the ToolDetails for both
FullName and SemanticVersion.
@tibbon
Copy link
Contributor Author

tibbon commented Apr 1, 2024

I'm having trouble adding tests for this, but I'm relatively new to Golang too. The module's name of sarif and importing sarif are mixing me up a lot for testing. :/

@ehsandeep ehsandeep merged commit 143f179 into projectdiscovery:dev Apr 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants