Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix utils and add goroutine leak unit tests #5112

Merged
merged 15 commits into from Apr 30, 2024
Merged

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Apr 26, 2024

Proposed changes

Note

test failure due to a minor issue in dependent utils pr , and should be fixed once it is resolved and merged

Great job by everyone involved 馃帀

After fix

 go test -v ./... -count=1
=== RUN   TestSimpleNuclei
[INF] Templates clustered: 14 (Reduced 10 Requests)
[nameserver-fingerprint] scanme.sh
[caa-fingerprint] scanme.sh
{"duration":"0:00:01","errors":"1","hosts":"1","matched":"2","percent":"94","requests":"16","rps":"25","startedAt":"2024-04-29T21:41:57.866863+05:30","templates":"24","total":"17"}
--- PASS: TestSimpleNuclei (6.72s)
=== RUN   TestSimpleNucleiRemote
[nameserver-fingerprint] scanme.sh
--- PASS: TestSimpleNucleiRemote (4.38s)
=== RUN   TestThreadSafeNuclei
=== RUN   TestThreadSafeNuclei/scanme.sh
[INF] Templates clustered: 14 (Reduced 10 Requests)
[caa-fingerprint] scanme.sh
[nameserver-fingerprint] scanme.sh
=== RUN   TestThreadSafeNuclei/honey.scanme.sh
[INF] Templates clustered: 14 (Reduced 10 Requests)
[caa-fingerprint] honey.scanme.sh
--- PASS: TestThreadSafeNuclei (8.79s)
    --- PASS: TestThreadSafeNuclei/scanme.sh (3.62s)
    --- PASS: TestThreadSafeNuclei/honey.scanme.sh (2.83s)
PASS
ok  	github.com/projectdiscovery/nuclei/v3/lib/tests	20.798s

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tarunKoyalwar

This comment was marked as outdated.

@tarunKoyalwar

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix goroutine leaks in nuclei
4 participants