Add helper function print_debug for debug purposes
#928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ice3man543
reviewed
Aug 18, 2021
v2/pkg/operators/common/dsl/dsl.go
Outdated
| @@ -245,6 +245,11 @@ var functions = map[string]govaluate.ExpressionFunction{ | |||
| data := deserialization.GenerateJavaGadget(gadget, cmd, encoding) | |||
| return data, nil | |||
| }, | |||
| // for debug purposes | |||
| "print_stdout": func(args ...interface{}) (interface{}, error) { | |||
| fmt.Println(args) | |||
There was a problem hiding this comment.
We should add a message before printing the debug values, stating they are from print_debug function. Something like this @yabeow
gologger.Info().Msgf("print_stdout debug value: ")
fmt.Println(args)There was a problem hiding this comment.
Nice suggestion! I've added this, please check again 👍
yabeow
changed the title
print_stdout for debug purposesprint_debug for debug purposes
|
lgtm! |
ehsandeep
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added an helper function called
print_debugin DSL. This function will help to print DSL variables / outputs to stdout usingfmt.Printlnfunction for debug purposes.Note: I've tried to use your
gologgerpackage but it always requires a format string so I used the standardfmtpackage instead.