Add Additional Generic Url Variables #935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address some of the items in #491 and #927.
This adds the following generic variables that are parsed from the url:
The
{{BaseURL}}
and{{Hostname}}
variables should remain unchanged in any templates.I broke out the code in the
Make
function within v2/pkg/protocols/http/build_request.go and added a generateVariables function. This felt like a more succinct way to handle this.It should be pretty easy to expand this for anything else, but this seemed like a good start.