Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: too many colons in address #192

Closed
nicoandmee opened this issue Nov 25, 2022 · 1 comment · Fixed by #193
Closed

Bug: too many colons in address #192

nicoandmee opened this issue Nov 25, 2022 · 1 comment · Fixed by #193
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@nicoandmee
Copy link
Contributor

Proxify version:

0.0.8

Current Behavior:

╰─➤  proxify -socks5-proxy 'socks5://51.91.197.148:10002' -output "$(date +%Y%m%d)"                                                                                                                                                                                     130 ↵

                       _ ___
   ___  _______ __ __ (_) _/_ __
  / _ \/ __/ _ \\ \ // / _/ // /
 / .__/_/  \___/_\_\/_/_/ \_, /
/_/                      /___/  v0.0.8

                projectdiscovery.io

[INF] HTTP Proxy Listening on 127.0.0.1:8888
[INF] Socks5 Proxy Listening on 127.0.0.1:10080
[INF] Saving proxify traffic to 20221125
[INF] Using upstream SOCKS5 proxies: ["socks5://51.91.197.148:10002"]
2022/11/25 08:19:57 [002] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [004] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [006] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [008] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:57 [010] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [012] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [014] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [016] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [018] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:19:58 [020] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:20:00 [024] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address
2022/11/25 08:20:00 [026] WARN: Cannot read TLS response from mitm'd server socks connect tcp: dial tcp: address socks5://51.91.197.148:10002: too many colons in address

Expected Behavior:

A colon should not be appended to the end of the address. As you see, I did not include it in my invocation.

Steps To Reproduce:

See command I ran

Anything else:

Thanks for making awesome tools :)

@nicoandmee nicoandmee added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 25, 2022
@nicoandmee
Copy link
Contributor Author

nicoandmee commented Nov 25, 2022

The issue seems to be the docs? https.go makes it appear the format should be host:port, no protocol prefix. If I am correct, let me know so I can submit a PR. <3

Clarification: When using host:port, it works without issue.

@ehsandeep ehsandeep linked a pull request Nov 25, 2022 that will close this issue
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 28, 2022
@ehsandeep ehsandeep added this to the proxify v0.0.9 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants